Re: [PATCH] move_pages.2: not return ENOENT if the page are already on the target nodes

From: Qian Cai
Date: Fri Dec 06 2019 - 13:00:23 EST




> On Dec 6, 2019, at 12:31 PM, Yang Shi <yang.shi@xxxxxxxxxxxxxxxxx> wrote:
>
> It looks since commit e78bbfa82624 ("mm: stop returning -ENOENT from sys_move_pages() if nothing got migrated") too, which reset err to 0 unconditionally. It seems it is on purpose by that commit the syscall caller should check status for the details according to the commit log.

I donât read it on purpose. âThere is no point in returning -ENOENT from sys_move_pages() if all pages
were already on the right nodeâ, so this is only taking about the pages in the desired node. Anyway, but now it is probably the best time to think outside the box redesigning this syscalls and nuke this whole mess.