Re: [PATCH] pipe: Fix iteration end check in fuse_dev_splice_write()

From: Mariusz Ceier
Date: Sat Dec 07 2019 - 14:33:59 EST


I can't reproduce it with ad910e36da4ca3a1bd436989f632d062dda0c921,
seems it fixes the issue.

Best regards,
Mariusz Ceier

On Sat, 7 Dec 2019 at 18:56, Linus Torvalds
<torvalds@xxxxxxxxxxxxxxxxxxxx> wrote:
>
> On Sat, Dec 7, 2019 at 10:30 AM Mariusz Ceier <mceier@xxxxxxxxx> wrote:
> >
> > I believe it's still not complete fix for 8cefc107ca54. Loading videos
> > (or streams) on youtube, twitch in firefox (71 or nightly) on kernel
> > eea2d5da29e396b6cc1fb35e36bcbf5f57731015 still results in page
> > rendering getting stuck (switching between tabs shows spinner instead
> > of page content).
>
> Ok, so youtube (unlike facebook), I can test in firefox. Although it's
> 70, not 71 or nightly. And it doesn't seem to fail for me.
>
> Of course, maybe the reason it doesn't fail for me is that I have a
> patch in my tree that may be the fix. It's a very small race in
> select()/poll(), and it's small enough that I wonder if it's really
> the fix for this, but hey, it might be.
>
> It also might be that your version of firefox is different, or just
> that you're hitting something else that I'm just not hitting.
>
> But I committed my patch and pushed it out, so that you could see if
> that fixes it for you.
>
> Linus