[PATCH 3.16 32/72] cfg80211: Purge frame registrations on iftype change

From: Ben Hutchings
Date: Sun Dec 08 2019 - 08:57:19 EST

3.16.79-rc1 review patch. If anyone has any objections, please let me know.


From: Denis Kenzior <denkenz@xxxxxxxxx>

commit c1d3ad84eae35414b6b334790048406bd6301b12 upstream.

Currently frame registrations are not purged, even when changing the
interface type. This can lead to potentially weird situations where
frames possibly not allowed on a given interface type remain registered
due to the type switching happening after registration.

The kernel currently relies on userspace apps to actually purge the
registrations themselves, this is not something that the kernel should
rely on.

Add a call to cfg80211_mlme_purge_registrations() to forcefully remove
any registrations left over prior to switching the iftype.

Signed-off-by: Denis Kenzior <denkenz@xxxxxxxxx>
Link: https://lore.kernel.org/r/20190828211110.15005-1-denkenz@xxxxxxxxx
Signed-off-by: Johannes Berg <johannes.berg@xxxxxxxxx>
Signed-off-by: Ben Hutchings <ben@xxxxxxxxxxxxxxx>
net/wireless/util.c | 1 +
1 file changed, 1 insertion(+)

--- a/net/wireless/util.c
+++ b/net/wireless/util.c
@@ -926,6 +926,7 @@ int cfg80211_change_iface(struct cfg8021

+ cfg80211_mlme_purge_registrations(dev->ieee80211_ptr);

err = rdev_change_virtual_intf(rdev, dev, ntype, flags, params);