Re: [PATCH] net/x25: add new state X25_STATE_5

[David Miller]

From: Martin Schiller <ms@xxxxxxxxxx>
Date: Mon, 09 Dec 2019 06:28:53 +0100

> On 2019-12-07 20:59, David Miller wrote:
>> From: Martin Schiller <ms@xxxxxxxxxx>
>> Date: Fri,  6 Dec 2019 14:34:18 +0100
>> 
>>> +	switch (frametype) {
>>> +
>>> +		case X25_CLEAR_REQUEST:
>> Please remove this unnecessary empty line.
>> 
>>> +			if (!pskb_may_pull(skb, X25_STD_MIN_LEN + 2))
>>> +				goto out_clear;
>> A goto path for a single call site?  Just inline the operations here.
> 
> Well, I was guided by the code style of the other states.
> I could add a patch to also clean up the other states.
> What do you think?

Leave the other states and existing code alone.

Make your new code reasonable.