Re: [PATCH 3/6] procfs: Use all-in-one vtime aware kcpustat accessor
From: Frederic Weisbecker
Date: Mon Dec 09 2019 - 10:50:51 EST
On Sun, Dec 08, 2019 at 05:57:47PM +0200, Paul Orlyk wrote:
> Looks like a copy-paste error. I think it should be:
>
> - guest_nice += cpustat[CPUTIME_USER];
> + guest_nice += cpustat[CPUTIME_GUEST_NICE];
>
> and
>
> - guest_nice = cpustat[CPUTIME_USER];
> + guest_nice = cpustat[CPUTIME_GUEST_NICE];
>
> With best regards,
> Paul Orlyk
Yes the fix should be applied soonish:
https://lore.kernel.org/lkml/20191205020344.14940-1-frederic@xxxxxxxxxx/
Thanks.
>
> On 11/21/19 4:44 AM, Frederic Weisbecker wrote:
> > + guest += cpustat[CPUTIME_GUEST];
> > + guest_nice += cpustat[CPUTIME_USER];
> > + sum += kstat_cpu_irqs_sum(i);
> >
> > + guest = cpustat[CPUTIME_GUEST];
> > + guest_nice = cpustat[CPUTIME_USER];
> > seq_printf(p, "cpu%d", i);