Re: [PATCH] ASoC: cs42l42: add missed regulator_bulk_disable in remove and fix probe failure
From: Mark Brown
Date: Mon Dec 09 2019 - 11:24:22 EST
On Fri, Dec 06, 2019 at 03:52:09PM +0800, Chuhong Yuan wrote:
> The driver forgets to call regulator_bulk_disable() in remove like that
> in probe failure.
> Besides, some failed branches in probe do not handle failure correctly.
> Add the missed call and revise wrong direct returns to fix it.
Same issue with runtime PM here.
Also please submit one patch per change, each with a clear changelog, as
covered in SubmittingPatches. This makes it much easier to review
things since it's easier to tell if the patch does what it was intended
to do. When splitting patches up git gui can be helpful, you can stage
and unstage individual lines by right clicking on them.
Description: PGP signature