Re: [PATCH] arm: multi_v7_config: Restore debugfs support

[Olof Johansson]

+Kevin, since this seems like something ideally we would see some
coverage of from Kernel CI at some point.


On Mon, Dec 9, 2019 at 1:29 AM Geert Uytterhoeven <geert@xxxxxxxxxxxxxx> wrote:
>
> Hi Marek,
>
> On Fri, Dec 6, 2019 at 1:51 PM Marek Szyprowski
> <m.szyprowski@xxxxxxxxxxx> wrote:
> > Commit fd7d58f0dbc3 ("ARM: multi_v7_defconfig: renormalize based on recent
> > additions") removed explicit enable line for CONFIG_DEBUG_FS, because
> > that feature has been selected by other enabled options: CONFIG_TRACING,
> > which were enabled by CONFIG_PERF_EVENTS.
> >
> > In meantime, commit 0e4a459f56c3 ("tracing: Remove unnecessary DEBUG_FS
> > dependency") removed the dependency between CONFIG_DEBUG_FS and
> > CONFIG_TRACING, so CONFIG_DEBUG_FS is no longer enabled in default builds.
> >
> > Enable it again explicitly, as debugfs support is essential for various
> > automated testing tools.
>
> ... and for systemd :-(
>
> E.g. with Debian 9 nfsroot:
>
>     [FAILED] Failed to mount /sys/kernel/debug.
>     See 'systemctl status sys-kernel-debug.mount' for details.
>     [DEPEND] Dependency failed for Local File Systems.
>     ...
>     You are in emergGive root password for maintenance
>     (or press Control-D to continue):
>
> > Signed-off-by: Marek Szyprowski <m.szyprowski@xxxxxxxxxxx>
>
> Thank you!
>
> Acked-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>
>
> This is gonna bite lots of people (and defconfigs)...

Looks like the in-tree affected defconfigs are:

olof@quad:~/work/arm-soc/arch/arm/configs (for-next) $ fgrep -L
CONFIG_DEBUG_FS $(fgrep -l CONFIG_PERF_EVENTS *)
aspeed_g4_defconfig
aspeed_g5_defconfig
exynos_defconfig
imx_v6_v7_defconfig
milbeaut_m10v_defconfig
mvebu_v7_defconfig
mxs_defconfig
oxnas_v6_defconfig
shmobile_defconfig
tegra_defconfig
olof@quad:~/work/arm-soc/arch/arm/configs (for-next) $

I'll revisit with patches for those later today.


-Olof