Re: [PATCH v5 2/2] iio: (bma400) add driver for the BMA400
From: Dan Robertson
Date: Mon Dec 09 2019 - 13:27:28 EST
On Sun, Dec 08, 2019 at 06:54:44PM -0800, Randy Dunlap wrote:
> On 12/8/19 5:43 PM, Dan Robertson wrote:
> > diff --git a/drivers/iio/accel/Kconfig b/drivers/iio/accel/Kconfig
> > index d4ef35aeb579..dc9bc646d403 100644
> > --- a/drivers/iio/accel/Kconfig
> > +++ b/drivers/iio/accel/Kconfig
> > @@ -112,6 +112,22 @@ config BMA220
> > To compile this driver as a module, choose M here: the
> > module will be called bma220_spi.
> > +config BMA400
> > + tristate "Bosch BMA400 3-Axis Accelerometer Driver"
> > + select REGMAP
> > + select BMA400_I2C if (I2C)
> What's with the parentheses? I see that there are roughly 2700
> "select ... if X" without parens and around 95 like
> "select ... if (" [using rough grep expressions].
> The parens are unnecessary. They are often used on complex
> expressions, but certainly not on simple ones (except in iio).
Good point. I'll remove it. I'll need the parentheses if/when SPI support is
added, but I'll add it when it is needed.
> > + help
> > + Say Y here if you want to build a driver for the Bosch BMA400
> > + triaxial acceleration sensor.
> > +
> > + To compile this driver as a module, choose M here: the
> > + module will be called bma400_core and you will also get
> > + bma400_i2c for I2C.
> iff I2C is set/enabled, so could be confusing.