Re: [PATCH] drm/vmwgfx: Replace deprecated PTR_RET

[Lukas Bulwahn]

On Mon, Dec 9, 2019 at 11:21 AM Julia Lawall <julia.lawall@xxxxxxxx> wrote:
>
> > De: "Lukas Bulwahn" <lukas.bulwahn@xxxxxxxxx>
> > Ã: "Thomas Hellstrom" <thellstrom@xxxxxxxxxx>, dri-devel@xxxxxxxxxxxxxxxxxxxxx
> > Cc: "David Airlie" <airlied@xxxxxxxx>, "Daniel Vetter" <daniel@xxxxxxxx>, "Sinclair Yeh" <syeh@xxxxxxxxxx>,
> > linux-graphics-maintainer@xxxxxxxxxx, kernel-janitors@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, "Lukas Bulwahn"
> > <lukas.bulwahn@xxxxxxxxx>
> > EnvoyÃ: Dimanche 8 DÃcembre 2019 18:53:28
> > Objet: [PATCH] drm/vmwgfx: Replace deprecated PTR_RET
>
> > Commit 508108ea2747 ("drm/vmwgfx: Don't refcount command-buffer managed
> > resource lookups during command buffer validation") slips in use of
> > deprecated PTR_RET. Use PTR_ERR_OR_ZERO instead.
> >
> > As the PTR_ERR_OR_ZERO is a bit longer than PTR_RET, we introduce
> > local variable ret for proper indentation and line-length limits.
>
> Is 0 actually possible?  I have the impression that it is not, but perhaps I missed something.
>

I did not sanity-check if 0 is possible before patch submission, just
cleaning the syntatic stuff here to prepare final removal of the
deprecated PTR_RET.
But as far as I see:

vmw_cmd_dx_clear_rendertarget_view
-> vmw_view_id_val_add
-> vmw_view_lookup
-> vmw_cmdbuf_res_lookup

which would then return a proper pointer/a non PTR_ERR value and
hence, it would be possible that PTR_ERR_OR_ZERO returns 0. It all
looks pretty sane.

Lukas