Re: [PATCH V4] scsi: avoid potential deadlock in iscsi_if_rx func
From: Lee Duncan
Date: Mon Dec 09 2019 - 19:41:47 EST
On 12/9/19 3:11 PM, Martin K. Petersen wrote:
>
> wubo,
>
>> In iscsi_if_rx func, after receiving one request through
>> iscsi_if_recv_msg func, iscsi_if_send_reply will be called to try to
>> reply the request in do-loop. If the return of iscsi_if_send_reply
>> func return -EAGAIN all the time, one deadlock will occur.
>>
>> For example, a client only send msg without calling recvmsg func, then
>> it will result in the watchdog soft lockup. The details are given as
>> follows,
>
>> Signed-off-by: Bo Wu <wubo40@xxxxxxxxxx>
>> Reviewed-by: Zhiqiang Liu <liuzhiqiang26@xxxxxxxxxx>
>> Reviewed-by: Lee Duncan <LDuncan@xxxxxxxx>
>
> I haven't seen a Reviewed-by: from Lee on this patch.
>
Martin:
My sincere apologies. I told wubo I had already reviewed the patch, so
he didn't need another Reviewed-by from me. I see I was wrong.
Please consider my:
Reviewed-by: Lee Duncan <lduncan@xxxxxxxx>
in the patch to be re-verified.