RE: [PATCH 1/2] hexagon: define ioremap_uc

From: Brian Cain
Date: Mon Dec 09 2019 - 20:05:34 EST


> -----Original Message-----
> From: linux-hexagon-owner@xxxxxxxxxxxxxxx <linux-hexagon-
> owner@xxxxxxxxxxxxxxx> On Behalf Of Nick Desaulniers
> Sent: Monday, December 9, 2019 4:30 PM
> To: bcain@xxxxxxxxxxxxxx
> Cc: Nick Desaulniers <ndesaulniers@xxxxxxxxxx>; lee.jones@xxxxxxxxxx;
> andriy.shevchenko@xxxxxxxxxxxxxxx; ztuowen@xxxxxxxxx;
> mika.westerberg@xxxxxxxxxxxxxxx; mcgrof@xxxxxxxxxx;
> gregkh@xxxxxxxxxxxxxxxxxxx; alexios.zavras@xxxxxxxxx;
> allison@xxxxxxxxxxx; will@xxxxxxxxxx; rfontana@xxxxxxxxxx;
> tglx@xxxxxxxxxxxxx; peterz@xxxxxxxxxxxxx; boqun.feng@xxxxxxxxx;
> mingo@xxxxxxxxxx; akpm@xxxxxxxxxxxxxxxxxxxx; geert@xxxxxxxxxxxxxx;
> linux-hexagon@xxxxxxxxxxxxxxx; clang-built-linux@xxxxxxxxxxxxxxxx; linux-
> kernel@xxxxxxxxxxxxxxx; Nathan Chancellor <natechancellor@xxxxxxxxx>
> Subject: [PATCH 1/2] hexagon: define ioremap_uc
>
> Similar to
> commit 38e45d81d14e ("sparc64: implement ioremap_uc") define
> ioremap_uc for hexagon to avoid errors from -Wimplicit-function-definition.
>
> Fixes: e537654b7039 ("lib: devres: add a helper function for ioremap_uc")
> Link: https://github.com/ClangBuiltLinux/linux/issues/797
> Suggested-by: Nathan Chancellor <natechancellor@xxxxxxxxx>
> Signed-off-by: Nick Desaulniers <ndesaulniers@xxxxxxxxxx>
> ---
> arch/hexagon/include/asm/io.h | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/hexagon/include/asm/io.h
> b/arch/hexagon/include/asm/io.h index 539e3efcf39c..b0dbc3473172
> 100644
> --- a/arch/hexagon/include/asm/io.h
> +++ b/arch/hexagon/include/asm/io.h
> @@ -173,6 +173,7 @@ static inline void writel(u32 data, volatile void
> __iomem *addr)
>
> void __iomem *ioremap(unsigned long phys_addr, unsigned long size);
> #define ioremap_nocache ioremap
> +#define ioremap_uc(X, Y) ioremap((X), (Y))
>
>
> #define __raw_writel writel
> --
> 2.24.0.393.g34dc348eaf-goog

Acked-by: Brian Cain <bcain@xxxxxxxxxxxxxx>