Re: [PATCH v5 2/4] lib: devres: add a helper function for ioremap_uc

[Geert Uytterhoeven]

On Mon, Nov 11, 2019 at 9:45 AM Lee Jones <lee.jones@xxxxxxxxxx> wrote:
> On Wed, 16 Oct 2019, Tuowen Zhao wrote:
> > Implement a resource managed strongly uncachable ioremap function.
> >
> > Cc: <stable@xxxxxxxxxxxxxxx>
> > Tested-by: AceLan Kao <acelan.kao@xxxxxxxxxxxxx>
> > Signed-off-by: Tuowen Zhao <ztuowen@xxxxxxxxx>
> > Acked-by: Mika Westerberg <mika.westerberg@xxxxxxxxxxxxxxx>
> > Acked-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
> > Acked-by: Luis Chamberlain <mcgrof@xxxxxxxxxx>
> > Acked-for-MFD-by: Lee Jones <lee.jones@xxxxxxxxxx>
> > ---
> >  include/linux/io.h |  2 ++
> >  lib/devres.c       | 19 +++++++++++++++++++
> >  2 files changed, 21 insertions(+)
>
> Applied, thanks.

This is now commit e537654b7039aacf ("lib: devres: add a helper function
for ioremap_uc") in upstream.

Do we really need this? There is only one user of ioremap_uc(), which
Christoph is trying hard to get rid of, and now you made it mandatory.
https://lore.kernel.org/dri-devel/20191112105507.GA7122@xxxxxx/

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds