[PATCH v2] selftests: fix build behaviour on targets' failures

From: Cristian Marussi
Date: Tue Dec 10 2019 - 06:45:18 EST

Currently, when some of the KSFT subsystems fails to build, the toplevel
KSFT Makefile just keeps carrying on with the build process.

This behaviour is expected and desirable especially in the context of a CI
system running KSelfTest, since it is not always easy to guarantee that the
most recent and esoteric dependencies are respected across all KSFT TARGETS
in a timely manner.

Unfortunately, as of now, this holds true only if the very last of the
built subsystems could have been successfully compiled: if the last of
those subsystem instead failed to build, such failure is taken as the whole
outcome of the Makefile target and the complete build/install process halts
even though many other preceding subsytems were in fact already built

Fix the KSFT Makefile behaviour related to all/install targets in order
to fail as a whole only when the all/install targets have failed for all
of the requested TARGETS, while succeeding when at least one of TARGETS
has been successfully built.

Signed-off-by: Cristian Marussi <cristian.marussi@xxxxxxx>
This patch is based on ksft/fixes branch from:


on top of commit (~5.5-rc1):

99e51aa8f701 Documentation: kunit: add documentation for kunit_tool

Building with either:

make kselftest-install \
TARGETS="exec arm64 bpf"

make -C tools/testing/selftests install \
TARGETS="exec arm64 bpf"

(with 'bpf' not building clean on my setup in the above case)

and veryfying that build/install completes if at least one of TARGETS can
be successfully built, and any successfully built subsystem is installed.

V1 --> V2
- rebased on 5.5-rc1
- rewording commit message
- dropped RFC tag
tools/testing/selftests/Makefile | 18 +++++++++++-------
1 file changed, 11 insertions(+), 7 deletions(-)

diff --git a/tools/testing/selftests/Makefile b/tools/testing/selftests/Makefile
index b001c602414b..86b2a3fca04d 100644
--- a/tools/testing/selftests/Makefile
+++ b/tools/testing/selftests/Makefile
@@ -143,11 +143,13 @@ else

all: khdr
- @for TARGET in $(TARGETS); do \
- mkdir $$BUILD_TARGET -p; \
- done;
+ @ret=1; \
+ for TARGET in $(TARGETS); do \
+ mkdir $$BUILD_TARGET -p; \
+ ret=$$((ret * $$?)); \
+ done; exit $$ret;

run_tests: all
@for TARGET in $(TARGETS); do \
@@ -196,10 +198,12 @@ ifdef INSTALL_PATH
install -m 744 kselftest/module.sh $(INSTALL_PATH)/kselftest/
install -m 744 kselftest/runner.sh $(INSTALL_PATH)/kselftest/
install -m 744 kselftest/prefix.pl $(INSTALL_PATH)/kselftest/
- @for TARGET in $(TARGETS); do \
+ @ret=1; \
+ for TARGET in $(TARGETS); do \
- done;
+ ret=$$((ret * $$?)); \
+ done; exit $$ret;

@# Ask all targets to emit their test scripts
echo "#!/bin/sh" > $(ALL_SCRIPT)