Re: [PATCH] mmc: sdhci: Update the tuning failed messages to pr_debug level

[Ulf Hansson]

On Fri, 6 Dec 2019 at 12:42, Faiz Abbas <faiz_abbas@xxxxxx> wrote:
>
> Tuning support in DDR50 speed mode was added in SD Specifications Part1
> Physical Layer Specification v3.01. Its not possible to distinguish
> between v3.00 and v3.01 from the SCR and that is why since
> commit 4324f6de6d2e ("mmc: core: enable CMD19 tuning for DDR50 mode")
> tuning failures are ignored in DDR50 speed mode.
>
> Cards compatible with v3.00 don't respond to CMD19 in DDR50 and this
> error gets printed during enumeration and also if retune is triggered at
> any time during operation. Update the printk level to pr_debug so that
> these errors don't lead to false error reports.
>
> Signed-off-by: Faiz Abbas <faiz_abbas@xxxxxx>

Applied for fixes and by adding a stable tag, thanks!

Kind regards
Uffe


> ---
>  drivers/mmc/host/sdhci.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/mmc/host/sdhci.c b/drivers/mmc/host/sdhci.c
> index 296d955ede59..42a9c8179da7 100644
> --- a/drivers/mmc/host/sdhci.c
> +++ b/drivers/mmc/host/sdhci.c
> @@ -2417,8 +2417,8 @@ static int __sdhci_execute_tuning(struct sdhci_host *host, u32 opcode)
>                 sdhci_send_tuning(host, opcode);
>
>                 if (!host->tuning_done) {
> -                       pr_info("%s: Tuning timeout, falling back to fixed sampling clock\n",
> -                               mmc_hostname(host->mmc));
> +                       pr_debug("%s: Tuning timeout, falling back to fixed sampling clock\n",
> +                                mmc_hostname(host->mmc));
>                         sdhci_abort_tuning(host, opcode);
>                         return -ETIMEDOUT;
>                 }
> --
> 2.19.2
>