Re: [PATCH net-next v2 5/5] ethtool: provide link mode names as a string set

From: Jiri Pirko
Date: Tue Dec 10 2019 - 09:27:53 EST

Tue, Dec 10, 2019 at 02:08:13PM CET, mkubecek@xxxxxxx wrote:
>Unlike e.g. netdev features, the ethtool ioctl interface requires link mode
>table to be in sync between kernel and userspace for userspace to be able
>to display and set all link modes supported by kernel. The way arbitrary
>length bitsets are implemented in netlink interface, this will be no longer
>To allow userspace to access all link modes running kernel supports, add
>table of ethernet link mode names and make it available as a string set to
>userspace GET_STRSET requests. Add build time check to make sure names
>are defined for all modes declared in enum ethtool_link_mode_bit_indices.
>Once the string set is available, make it also accessible via ioctl.
>Signed-off-by: Michal Kubecek <mkubecek@xxxxxxx>

Reviewed-by: Jiri Pirko <jiri@xxxxxxxxxxxx>