Re: [PATCH net-next v2 1/5] rtnetlink: provide permanent hardware address in RTM_NEWLINK

From: Jiri Pirko
Date: Tue Dec 10 2019 - 13:43:50 EST


Tue, Dec 10, 2019 at 06:51:05PM CET, jakub.kicinski@xxxxxxxxxxxxx wrote:
>On Tue, 10 Dec 2019 14:07:53 +0100 (CET), Michal Kubecek wrote:
>> @@ -1822,6 +1826,7 @@ static const struct nla_policy ifla_policy[IFLA_MAX+1] = {
>> [IFLA_PROP_LIST] = { .type = NLA_NESTED },
>> [IFLA_ALT_IFNAME] = { .type = NLA_STRING,
>> .len = ALTIFNAMSIZ - 1 },
>> + [IFLA_PERM_ADDRESS] = { .type = NLA_REJECT },
>> };
>>
>> static const struct nla_policy ifla_info_policy[IFLA_INFO_MAX+1] = {
>
>Jiri, I just noticed ifla_policy didn't get strict_start_type set when
>ALT_IFNAME was added, should we add it in net? ð

Hmm, I guess that is a good idea.