Re: [PATCH] arm64: dts: meson-a1: add I2C nodes

[Jian Hu]

Hi jerome

Thanks for your review

On 2019/12/10 18:17, Jerome Brunet wrote:
> On Mon 02 Dec 2019 at 12:12, Jian Hu <jian.hu@xxxxxxxxxxx> wrote:
>
> > There are four I2C controllers in A1 series,
> > Share the same comptible with AXG.The I2C nodes
> > depend on pinmux and clock controller.
> >
> > Signed-off-by: Jian Hu <jian.hu@xxxxxxxxxxx>
> > ---
> >   arch/arm64/boot/dts/amlogic/meson-a1.dtsi | 149 ++++++++++++++++++++++
> >   1 file changed, 149 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/amlogic/meson-a1.dtsi b/arch/arm64/boot/dts/amlogic/meson-a1.dtsi
> > index eab2ecd36aa8..d0a73d953f5e 100644
> > --- a/arch/arm64/boot/dts/amlogic/meson-a1.dtsi
> > +++ b/arch/arm64/boot/dts/amlogic/meson-a1.dtsi
> > @@ -16,6 +16,13 @@
> >   	#address-cells = <2>;
> >   	#size-cells = <2>;
> >   
> > +	aliases {
> > +		i2c0 = &i2c0;
> > +		i2c1 = &i2c1;
> > +		i2c2 = &i2c2;
> > +		i2c3 = &i2c3;
> > +	};
> > +
>
> I wonder if assigning i2c bus alias in the SoC dtsi is such a good idea.
>
> Such aliases are usually assigned as needed by each board design:
> meson-a1-ad401.dts in your case.
You are right, I will set i2c bus alias in dts file.
> .