Re: [PATCH AUTOSEL 4.14 077/130] rfkill: allocate static minor

[Greg Kroah-Hartman]

On Tue, Dec 10, 2019 at 05:02:08PM -0500, Sasha Levin wrote:
> From: Marcel Holtmann <marcel@xxxxxxxxxxxx>
> 
> [ Upstream commit 8670b2b8b029a6650d133486be9d2ace146fd29a ]
> 
> udev has a feature of creating /dev/<node> device-nodes if it finds
> a devnode:<node> modalias. This allows for auto-loading of modules that
> provide the node. This requires to use a statically allocated minor
> number for misc character devices.
> 
> However, rfkill uses dynamic minor numbers and prevents auto-loading
> of the module. So allocate the next static misc minor number and use
> it for rfkill.
> 
> Signed-off-by: Marcel Holtmann <marcel@xxxxxxxxxxxx>
> Link: https://lore.kernel.org/r/20191024174042.19851-1-marcel@xxxxxxxxxxxx
> Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
> Signed-off-by: Sasha Levin <sashal@xxxxxxxxxx>
> ---
>  include/linux/miscdevice.h | 1 +
>  net/rfkill/core.c          | 9 +++++++--
>  2 files changed, 8 insertions(+), 2 deletions(-)

This is not needed in older kernels, please do not backport it unless
the networking developers _REALLY_ think it is necessary.

thanks,

greg k-h