Re: [PATCH] gpio: aspeed: avoid return type warning
From: Bartosz Golaszewski
Date: Wed Dec 11 2019 - 04:08:01 EST
wt., 10 gru 2019 o 23:10 Andrew Jeffery <andrew@xxxxxxxx> napisaÅ(a):
>
>
>
> On Wed, 11 Dec 2019, at 06:58, Arnd Bergmann wrote:
> > gcc has a hard time tracking whether BUG_ON(1) ends
> > execution or not:
> >
> > drivers/gpio/gpio-aspeed-sgpio.c: In function 'bank_reg':
> > drivers/gpio/gpio-aspeed-sgpio.c:112:1: error: control reaches end of
> > non-void function [-Werror=return-type]
> >
> > Use the simpler BUG() that gcc knows cannot continue.
> >
> > Fixes: f8b410e3695a ("gpio: aspeed-sgpio: Rename and add Kconfig/Makefile")
> > Signed-off-by: Arnd Bergmann <arnd@xxxxxxxx>
>
> Acked-by: Andrew Jeffery <andrew@xxxxxxxx>
Applied for fixes.
Bartosz