Re: [PATCH v4] crypto: arm64/sha: fix function types

From: Herbert Xu
Date: Wed Dec 11 2019 - 04:40:33 EST


On Wed, Nov 27, 2019 at 03:55:03PM -0800, Sami Tolvanen wrote:
> Instead of casting pointers to callback functions, add C wrappers
> to avoid type mismatch failures with Control-Flow Integrity (CFI)
> checking.
>
> Signed-off-by: Sami Tolvanen <samitolvanen@xxxxxxxxxx>
> Reviewed-by: Ard Biesheuvel <ardb@xxxxxxxxxx>
> ---
> Changes in v4:
> - Removed unnecessary returns.
>
> Changes in v3:
> - Removed unnecessary inline attributes.
>
> Changes in v2:
> - Added wrapper functions instead of changing parameter types
> for the assembly functions.
>
> ---
> arch/arm64/crypto/sha1-ce-glue.c | 17 +++++++++------
> arch/arm64/crypto/sha2-ce-glue.c | 34 ++++++++++++++++++------------
> arch/arm64/crypto/sha256-glue.c | 32 +++++++++++++++++-----------
> arch/arm64/crypto/sha512-ce-glue.c | 26 ++++++++++++-----------
> arch/arm64/crypto/sha512-glue.c | 15 ++++++++-----
> 5 files changed, 76 insertions(+), 48 deletions(-)

Patch applied. Thanks.
--
Email: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt