Re: [PATCH v3 2/2] gpio: bcm-kona: use platform_irq_count

[Uwe Kleine-König]

On Wed, Dec 11, 2019 at 10:30:33AM +0100, Bartosz Golaszewski wrote:
> År., 4 gru 2019 o 11:09 Uwe Kleine-KÃnig
> <u.kleine-koenig@xxxxxxxxxxxxxx> napisaÅ(a):
> >
> > On Wed, Dec 04, 2019 at 09:24:39AM +0000, Peng Fan wrote:
> > > From: Peng Fan <peng.fan@xxxxxxx>
> > >
> > > platform_irq_count() is the more generic way (independent of
> > > device trees) to determine the count of available interrupts. So
> > > use this instead.
> > >
> > > As platform_irq_count() might return an error code (which
> > > of_irq_count doesn't) some additional handling is necessary.
> > >
> > > Signed-off-by: Peng Fan <peng.fan@xxxxxxx>
> > > ---
> > >
> > > V3:
> > >  Use %pe
> >
> > Great. Note that with %pe there is a dependency on commit 57f5677e535b
> > ("printf: add support for printing symbolic error names") which was
> > applied during the current merge window.
> >
> 
> Why would %pe be better in this case? The function returned an int -
> why convert it to a pointer?

The conversion to a pointer is (currently still) needed, because there
is no printk facility (yet) that consumes an int error pointer and
results in the respecting code.

Somewhere on my todo-list is an item to fix that, but we're not there
yet and so the best option is to use %pe.

Best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-KÃnig            |
Industrial Linux Solutions                 | https://www.pengutronix.de/ |