Re: [PATCH] ARM: davinci: select CONFIG_RESET_CONTROLLER
From: Sekhar Nori
Date: Wed Dec 11 2019 - 05:13:45 EST
Hi Arnd,
On 11/12/19 1:21 AM, Arnd Bergmann wrote:
> Selecting RESET_CONTROLLER is actually required, otherwise we
> can get a link failure in the clock driver:
>
> drivers/clk/davinci/psc.o: In function `__davinci_psc_register_clocks':
> psc.c:(.text+0x9a0): undefined reference to `devm_reset_controller_register'
> drivers/clk/davinci/psc-da850.o: In function `da850_psc0_init':
> psc-da850.c:(.text+0x24): undefined reference to `reset_controller_add_lookup'
>
> Fixes: f962396ce292 ("ARM: davinci: support multiplatform build for ARM v5")
> Cc: <stable@xxxxxxxxxxxxxxx> # v5.4
> Signed-off-by: Arnd Bergmann <arnd@xxxxxxxx>
Assuming you are going to apply directly to ARM-SoC,
Acked-by: Sekhar Nori <nsekhar@xxxxxx>
Thanks,
Sekhar
> ---
> arch/arm/mach-davinci/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm/mach-davinci/Kconfig b/arch/arm/mach-davinci/Kconfig
> index dd427bd2768c..02b180ad7245 100644
> --- a/arch/arm/mach-davinci/Kconfig
> +++ b/arch/arm/mach-davinci/Kconfig
> @@ -9,6 +9,7 @@ menuconfig ARCH_DAVINCI
> select PM_GENERIC_DOMAINS if PM
> select PM_GENERIC_DOMAINS_OF if PM && OF
> select REGMAP_MMIO
> + select RESET_CONTROLLER
> select HAVE_IDE
> select PINCTRL_SINGLE
>
> --
> 2.20.0
>