Re: [PATCH] drm/vmwgfx: prevent memory leak in vmw_cmdbuf_res_add

[Thomas Hellstrom]

On 9/25/19 6:38 AM, Navid Emamdoost wrote:
> In vmw_cmdbuf_res_add if drm_ht_insert_item fails the allocated memory
> for cres should be released.
>
> Signed-off-by: Navid Emamdoost <navid.emamdoost@xxxxxxxxx>
> ---
>  drivers/gpu/drm/vmwgfx/vmwgfx_cmdbuf_res.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_cmdbuf_res.c b/drivers/gpu/drm/vmwgfx/vmwgfx_cmdbuf_res.c
> index 4ac55fc2bf97..44d858ce4ce7 100644
> --- a/drivers/gpu/drm/vmwgfx/vmwgfx_cmdbuf_res.c
> +++ b/drivers/gpu/drm/vmwgfx/vmwgfx_cmdbuf_res.c
> @@ -209,8 +209,10 @@ int vmw_cmdbuf_res_add(struct vmw_cmdbuf_res_manager *man,
>  
>  	cres->hash.key = user_key | (res_type << 24);
>  	ret = drm_ht_insert_item(&man->resources, &cres->hash);
> -	if (unlikely(ret != 0))
> +	if (unlikely(ret != 0)) {
> +		kfree(cres);
>  		goto out_invalid_key;
> +	}
>  
>  	cres->state = VMW_CMDBUF_RES_ADD;
>  	cres->res = vmw_resource_reference(res);

Reviewed-by: Thomas Hellstrom <thellstrom@xxxxxxxxxx>

Will be part of next vmwgfx-next pull.

Thanks,

Thomas