RE: [PATCH] cpuidle: Drop unnecessary type cast in cpuidle_poll_time()
From: Zhang, Rui
Date: Wed Dec 11 2019 - 05:33:12 EST
> -----Original Message-----
> From: linux-pm-owner@xxxxxxxxxxxxxxx [mailto:linux-pm-
> owner@xxxxxxxxxxxxxxx] On Behalf Of Rafael J. Wysocki
> Sent: Wednesday, December 11, 2019 6:31 PM
> To: Linux PM <linux-pm@xxxxxxxxxxxxxxx>
> Cc: LKML <linux-kernel@xxxxxxxxxxxxxxx>; Daniel Lezcano
> <daniel.lezcano@xxxxxxxxxx>
> Subject: [PATCH] cpuidle: Drop unnecessary type cast in cpuidle_poll_time()
>
> From: Rafael J. Wysocki <rafael.j.wysocki@xxxxxxxxx>
>
> The data type of the target_residency_ns field in struct cpuidle_state is u64,
> so it does not need to be cast into u64.
>
> Get read of the unnecessary type cast.
s/read/rid
thanks,
rui
>
> Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@xxxxxxxxx>
> ---
>
> On top of the linux-next branch of linux-pm.git from today.
>
> ---
> drivers/cpuidle/cpuidle.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> Index: linux-pm/drivers/cpuidle/cpuidle.c
> ==============================================================
> =====
> --- linux-pm.orig/drivers/cpuidle/cpuidle.c
> +++ linux-pm/drivers/cpuidle/cpuidle.c
> @@ -381,7 +381,7 @@ u64 cpuidle_poll_time(struct cpuidle_dri
> if (dev->states_usage[i].disable)
> continue;
>
> - limit_ns = (u64)drv->states[i].target_residency_ns;
> + limit_ns = drv->states[i].target_residency_ns;
> break;
> }
>
>
>