Re: [PATCH v3 3/6] mfd: rn5t618: add irq support

[Andreas Kemnade]

On Wed, 11 Dec 2019 07:50:21 +0000
Lee Jones <lee.jones@xxxxxxxxxx> wrote:

[...]
> > > > +
> > > >  static const struct i2c_device_id rn5t618_i2c_id[] = {
> > > >  	{ }
> > > >  };
> > > >  MODULE_DEVICE_TABLE(i2c, rn5t618_i2c_id);    
> > > 
> > > Not this patch I know, but it's strange to see this empty.  
> > 
> > Yes, should be cleaned up. For now the device tree stuff seems to kick in.  
> 
> I think this can be removed completely.
> 
> Just make sure you use .probe2 and it should be automatic.
> 
Hmm, I cannot find probe2 but probe_new. So you mean probe_new?

I will send a separate cleanup patch

Regards,
Andreas

Attachment: pgpZP4u95PUgi.pgp
Description: OpenPGP digital signature