Re: [PATCH RFC 4/8] drm/sprd: add Unisoc's drm display controller driver

[Emil Velikov]

On Wed, 11 Dec 2019 at 09:18, tang pengchuan <kevin3.tang@xxxxxxxxx> wrote:
>
> Hi
>
> Emil Velikov <emil.l.velikov@xxxxxxxxx> ä2019å12æ11æåä äå1:14åéï
>>
>> Hi Kevin,
>>
>> On Tue, 10 Dec 2019 at 08:41, Kevin Tang <kevin3.tang@xxxxxxxxx> wrote:
>> >
>> > From: Kevin Tang <kevin.tang@xxxxxxxxxx>
>> >
>> > Adds DPU(Display Processor Unit) support for the Unisoc's display subsystem.
>> > It's support multi planes, scaler, rotation, PQ(Picture Quality) and more.
>> >
>> > Cc: Orson Zhai <orsonzhai@xxxxxxxxx>
>> > Cc: Baolin Wang <baolin.wang@xxxxxxxxxx>
>> > Cc: Chunyan Zhang <zhang.lyra@xxxxxxxxx>
>> > Signed-off-by: Kevin Tang <kevin.tang@xxxxxxxxxx>
>> > ---
>> >  drivers/gpu/drm/sprd/Makefile       |    6 +-
>> >  drivers/gpu/drm/sprd/disp_lib.c     |  290 +++++++
>> >  drivers/gpu/drm/sprd/disp_lib.h     |   40 +
>> >  drivers/gpu/drm/sprd/dpu/Makefile   |    8 +
>> >  drivers/gpu/drm/sprd/dpu/dpu_r2p0.c | 1464 +++++++++++++++++++++++++++++++++++
>> >  drivers/gpu/drm/sprd/sprd_dpu.c     | 1152 +++++++++++++++++++++++++++
>> >  drivers/gpu/drm/sprd/sprd_dpu.h     |  217 ++++++
>> >  7 files changed, 3176 insertions(+), 1 deletion(-)
>>
>> As we can see from the diff stat this patch is huge. So it would be fairly hard
>> to provide meaningful review as-is.
>>
>> One can combine my earlier suggestion (to keep modeset/atomic out of 2/8), with
>> the following split:
>>  - 4/8 add basic atomic modeset support - one format, one rotation 0, no extra
>>  attributes
>>  - 5/8 add extra formats
>>  - 6/8 add extra rotation support
>>  - ... add custom attributes
>
> Ok, i will split this patch, upstream modeset and atomic at first. clock, gloabl, enhance, extra
> attributes  and so on will be upload later.

Amazing thank you. Please apply the similar logic and split patch 6/8
- that patch is twice larger than this one.

Some small general requests - please use plain text emails (see [1])
and trim unrelated fragments when replying.
Otherwise it is very easy to miss the comment that you and others have made.

HTH
Emil

[1] https://www.lifewire.com/how-to-send-a-message-in-plain-text-from-gmail-1171963