Re: [PATCH 2/7] Input: aiptek: fix endpoint sanity check

[Vladis Dronov]

A fix for a bug indeed, thank you Johan.

Best regards,
Vladis Dronov | Red Hat, Inc. | The Core Kernel | Senior Software Engineer

----- Original Message -----
> From: "Johan Hovold" <johan@xxxxxxxxxx>
> To: "Dmitry Torokhov" <dmitry.torokhov@xxxxxxxxx>
> Cc: linux-input@xxxxxxxxxxxxxxx, linux-usb@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, "Johan Hovold"
> <johan@xxxxxxxxxx>, "stable" <stable@xxxxxxxxxxxxxxx>, "Vladis Dronov" <vdronov@xxxxxxxxxx>
> Sent: Tuesday, December 10, 2019 12:37:32 PM
> Subject: [PATCH 2/7] Input: aiptek: fix endpoint sanity check
> 
> The driver was checking the number of endpoints of the first alternate
> setting instead of the current one, something which could lead to the
> driver binding to an invalid interface.
> 
> This in turn could cause the driver to misbehave or trigger a WARN() in
> usb_submit_urb() that kernels with panic_on_warn set would choke on.
> 
> Fixes: 8e20cf2bce12 ("Input: aiptek - fix crash on detecting device without
> endpoints")
> Cc: stable <stable@xxxxxxxxxxxxxxx>     # 4.4
> Cc: Vladis Dronov <vdronov@xxxxxxxxxx>
> Signed-off-by: Johan Hovold <johan@xxxxxxxxxx>