Re: [PATCH 0/2] PM: Add a switch for disabling/enabling sync() before suspend

From: Jonas Meurer
Date: Wed Dec 11 2019 - 10:59:48 EST


Hello,

Jonas Meurer:
> Hello,
>
> Introduce a new run-time sysfs switch to disable/enable sync() before
> system suspend. This is useful to avoid races and deadlocks if block
> devices have been suspended before, e.g. by 'cryptsetup luksSuspend'.
>
> The second patch changes the behaviour of build-time switch
> 'CONFIG_SUSPEND_SKIP_SYNC' accordingly, using the build-time switch value
> as default for our new run-time switch '/sys/power/sync_on_suspend'.
>
> Jonas Meurer (2):
> PM: Add a switch for disabling/enabling sync() before suspend
> PM: CONFIG_SUSPEND_SKIP_SYNC sets default for '/sys/power/sync_on_suspend'
>
> Documentation/ABI/testing/sysfs-power | 15 +++++++++++++++
> include/linux/suspend.h | 2 ++
> kernel/power/Kconfig | 5 ++++-
> kernel/power/main.c | 33 +++++++++++++++++++++++++++++++++
> kernel/power/suspend.c | 2 +-
> 5 files changed, 55 insertions(+), 2 deletions(-)

Any chance to get a review/comment on this patch? What's the next
logical steps to get it merged?

Cheers
jonas