Re: [PATCH v2 2/2] pinctrl: qcom: sc7180: Add new qup functions

From: Doug Anderson
Date: Wed Dec 11 2019 - 13:04:16 EST


On Tue, Dec 10, 2019 at 11:07 PM Rajendra Nayak <rnayak@xxxxxxxxxxxxxx> wrote:
> On 12/11/2019 12:08 PM, Bjorn Andersson wrote:
> > On Tue 10 Dec 21:24 PST 2019, Rajendra Nayak wrote:
> >
> >> on sc7180 we have cases where multiple functions from the same
> >> qup instance share the same pin. This is true for qup02/04/11 and qup13.
> >> Add new function names to distinguish which qup function to use.
> >>
> >> The device tree files for this platform haven't landed in mainline yet,
> >> so there aren't any users upstream who should break with this change
> >> in function names, however, anyone using the devicetree files that were
> >> posted on the lists and using these specific function names will need
> >> to update their changes.
> >
> > I don't think this paragraph adds value to the git log, but the patch
> > looks good.
> Right, I should have mentioned that bit after the --- so its not in the
> changelog :/
> Linus, do you want me to resend with that paragraph moved below --- ?

Personally I find this type of info useful even in the changelog
itself. Without it someone inspecting this change would wonder why it
was OK to change the device tree bindings without an attempt at
backward compatibility. I suppose they could always go back to the
mailing list and track down the history, but why is it bad to be in
the changelog?

In any case, if everyone hates it in the change log I won't stand in
the way, so regardless of which way folks go on that:

Reviewed-by: Douglas Anderson <dianders@xxxxxxxxxxxx>