RE: [PATCH] Fix tx_table init in rndis_set_subchannel()

[Haiyang Zhang]

> -----Original Message-----
> From: linux-hyperv-owner@xxxxxxxxxxxxxxx <linux-hyperv-
> owner@xxxxxxxxxxxxxxx> On Behalf Of David Miller
> Sent: Wednesday, December 11, 2019 5:22 PM
> To: Haiyang Zhang <haiyangz@xxxxxxxxxxxxx>
> Cc: sashal@xxxxxxxxxx; linux-hyperv@xxxxxxxxxxxxxxx; netdev@xxxxxxxxxxxxxxx;
> KY Srinivasan <kys@xxxxxxxxxxxxx>; Stephen Hemminger
> <sthemmin@xxxxxxxxxxxxx>; olaf@xxxxxxxxx; vkuznets
> <vkuznets@xxxxxxxxxx>; linux-kernel@xxxxxxxxxxxxxxx
> Subject: Re: [PATCH] Fix tx_table init in rndis_set_subchannel()
> 
> From: Haiyang Zhang <haiyangz@xxxxxxxxxxxxx>
> Date: Wed, 11 Dec 2019 13:59:03 -0800
> 
> > Host can provide send indirection table messages anytime after RSS is
> > enabled by calling rndis_filter_set_rss_param(). So the host provided
> > table values may be overwritten by the initialization in
> > rndis_set_subchannel().
> >
> > To prevent this problem, move the tx_table initialization before
> > calling rndis_filter_set_rss_param().
> >
> > Fixes: a6fb6aa3cfa9 ("hv_netvsc: Set tx_table to equal weight after
> > subchannels open")
> > Signed-off-by: Haiyang Zhang <haiyangz@xxxxxxxxxxxxx>
> 
> Please format your subject lines properly.
> 
> 	[PATCH $version $GIT_TREE] $subsystem_prefix: $description
> 
> Even the Fixes: tag had the proper subsystem prefix in it.
> 
> So your next posting must be of the form:
> 
> 	[PATCH v2 net] hv_netvsc: Fix tx_table init in rndis_set_subchannel().

Will do. Thanks.