Re: [PATCH] x86/microcode: make stub function static inline

[Valdis KlÄtnieks]

On Wed, 11 Dec 2019 22:38:19 +0100, Borislav Petkov said:

> >   CHECK   arch/x86/kernel/cpu/microcode/core.c
> > ./arch/x86/include/asm/microcode_amd.h:56:6: warning: symbol 'reload_ucode_amd' was not declared. Should it be static?
> >   CC      arch/x86/kernel/cpu/microcode/core.o
> > In file included from arch/x86/kernel/cpu/microcode/core.c:36:
> > ./arch/x86/include/asm/microcode_amd.h:56:6: warning: no previous prototype for 'reload_ucode_amd' [-Wmissing-prototypes
> > ]
>
> Hmm, I don't see this with gcc 9.2 and sparse 0.6.1 here.

Were you building with W=1 (so gcc issues extra warnings) and C=1 or 2 so sparse is run?

Attachment: pgpMdIgFHQIFQ.pgp
Description: PGP signature