Re: [PATCH v1 7/7] fsi: aspeed: add unspecified HAS_IOMEM dependency
From: Brendan Higgins
Date: Wed Dec 11 2019 - 19:30:17 EST
On Wed, Dec 11, 2019 at 4:12 PM Joel Stanley <joel@xxxxxxxxx> wrote:
> On Wed, 11 Dec 2019 at 19:28, Brendan Higgins <brendanhiggins@xxxxxxxxxx> wrote:
> > Currently CONFIG_FSI_MASTER_ASPEED=y implicitly depends on
> > CONFIG_HAS_IOMEM=y; consequently, on architectures without IOMEM we get
> > the following build error:
> > ld: drivers/fsi/fsi-master-aspeed.o: in function `fsi_master_aspeed_probe':
> > drivers/fsi/fsi-master-aspeed.c:436: undefined reference to `devm_ioremap_resource'
> > Fix the build error by adding the unspecified dependency.
> > Reported-by: Brendan Higgins <brendanhiggins@xxxxxxxxxx>
> > Signed-off-by: Brendan Higgins <brendanhiggins@xxxxxxxxxx>
> Nice. I hit this when attempting to force on CONFIG_COMPILE_TEST in
> order to build some ARM drivers under UM. Do you have plans to fix
> that too?
The only broken configs I found for UML are all listed on the cover
letter of this patch. I think fixing COMPILE_TEST on UM could be
worthwhile. Did you see any brokenness other than what I mentioned on
the cover letter?
> Do you want to get this in a fix for 5.5?
> Acked-by: Joel Stanley <joel@xxxxxxxxx>