Re: [PATCH 0/2] pipe: Fixes [ver #2]
From: Linus Torvalds
Date: Wed Dec 11 2019 - 20:29:03 EST
On Wed, Dec 11, 2019 at 12:55 PM David Howells <dhowells@xxxxxxxxxx> wrote:
> Is it worth reverting:
> commit f94df9890e98f2090c6a8d70c795134863b70201
> Add wake_up_interruptible_sync_poll_locked()
> since you changed the code that was calling that new function and so it's no
> longer called?
You are sure you won't want that for the notification queue cases? I
guess they'll never want to "sync" part..
Looking at the regular pipe read/write code, maybe we'll want to try
it again - do the wakeup while we already have the spinlock, rather
than later. But I have this suspicion that that might just then push
things into mutex contention, so who knows..
Regardless, it's not going to happen for 5.5, so I guess we could
revert it and if we ever end up trying it again we can resurrect it.