Re: [PATCH 6/6] KVM: Fix some writing mistakes

[linmiaohe]

Sean Christopherson wrote:
>On Wed, Dec 11, 2019 at 02:26:25PM +0800, linmiaohe wrote:
>> From: Miaohe Lin <linmiaohe@xxxxxxxxxx>
>> 
>> Fix some writing mistakes in the comments.
>> 
>> Signed-off-by: Miaohe Lin <linmiaohe@xxxxxxxxxx>
>> ---
>>  	 * This context will save all necessary information to walk page tables
>> -	 * of the an L2 guest. This context is only initialized for page table
>> +	 * of the L2 guest. This context is only initialized for page table
>
>I'd whack "the" instead of "and", i.e. ...walk page tables of an L2 guest, as KVM isn't limited to just one L2 guest.

I'd change this.

>>  	 * walking and not for faulting since we never handle l2 page faults 
>> on
>
>While you're here, want to change "l2" to "L2"?

I do nothing here. :)

>>  	 * the host.
>>  	 */
>> check_user_page_hwpoison(unsigned long addr)
>>  /*
>>   * The fast path to get the writable pfn which will be stored in @pfn,
>>   * true indicates success, otherwise false is returned.  It's also 
>> the
>> - * only part that runs if we can are in atomic context.
>> + * only part that runs if we can in atomic context.
>
>This should remove "can" instead of "are", i.e. ...part that runs if we are in atomic context.  The comment is calling out that hva_to_pfn() will return immediately if hva_to_pfn_fast() and the kernel is atomic context.
>

Many thanks for your explanation, I would change this too. And many thanks for your review.