Re: [PATCH v3 2/4] xenbus: limit when state is forced to closed

From: JÃrgen GroÃ
Date: Thu Dec 12 2019 - 01:02:22 EST

On 11.12.19 16:29, Paul Durrant wrote:
If a driver probe() fails then leave the xenstore state alone. There is no
reason to modify it as the failure may be due to transient resource
allocation issues and hence a subsequent probe() may succeed.

If the driver supports re-binding then only force state to closed during
remove() only in the case when the toolstack may need to clean up. This can
be detected by checking whether the state in xenstore has been set to
closing prior to device removal.

NOTE: Re-bind support is indicated by new boolean in struct xenbus_driver,
which defaults to false. Subsequent patches will add support to
some backend drivers.

Signed-off-by: Paul Durrant <pdurrant@xxxxxxxxxx>

Reviewed-by: Juergen Gross <jgross@xxxxxxxx>