Re: [PATCH V2] tpm_tis_spi: use new `delay` structure for SPI transfer delays

From: Ardelean, Alexandru
Date: Thu Dec 12 2019 - 02:21:41 EST


On Wed, 2019-12-11 at 19:37 +0200, Jarkko Sakkinen wrote:
> [External]
>
> On Tue, Dec 10, 2019 at 08:56:19AM +0200, Alexandru Ardelean wrote:
> > In a recent change to the SPI subsystem [1], a new `delay` struct was
> > added
> > to replace the `delay_usecs`. This change replaces the current
> > `delay_usecs`
> > with `delay` for this driver.
> >
> > The `spi_transfer_delay_exec()` function [in the SPI framework] makes
> > sure
> > that both `delay_usecs` & `delay` are used (in this order to preserve
> > backwards compatibility).
> >
> > [1] commit bebcfd272df6485 ("spi: introduce `delay` field for
> > `spi_transfer` + spi_transfer_delay_exec()")
>
> Not sure why you use ` and not '?

That's a habit from Github's Markdown.
We keep our kernel repo on Github and Markdown formats `text` into a
certain form.
When I open a PR, the PR text is formatted to highlight certain elements
[that I want highlighted].
I did not get any comments on it so far.

I can change it if you want.

As a secondary note: Markdown seems to be used on Gitlab and Bitbucket

Thanks
Alex

>
> /Jarkko