Re: [PATCH -next v2] pinctrl: samsung: fix build error without CONFIG_OF_GPIO

[Krzysztof Kozlowski]

On Thu, 12 Dec 2019 at 10:30, Chen Zhou <chenzhou10@xxxxxxxxxx> wrote:
>
> If CONFIG_OF_GPIO is n, build fails:
>
> drivers/pinctrl/samsung/pinctrl-samsung.c: In function samsung_gpiolib_register:
> drivers/pinctrl/samsung/pinctrl-samsung.c:969:5: error: struct gpio_chip has no member named of_node
>    gc->of_node = bank->of_node;
>
> Use #ifdef to guard this.
>
> Reported-by: Hulk Robot <hulkci@xxxxxxxxxx>
> Signed-off-by: Chen Zhou <chenzhou10@xxxxxxxxxx>
> ---
>  drivers/pinctrl/samsung/pinctrl-samsung.c | 2 ++
>  1 file changed, 2 insertions(+)

I was thinking about adding OF_GPIO but I could not trigger such case
as you mention. How can I reproduce this?

Anyway, the select/dependencies in Kconfig should be fixed up -
PINCTRL_SAMSUNG should depend on OF and GPIOLIB.

Best regards,
Krzysztof