Re: [PATCH v2 9/9] arm64: dts: rockchip: RockPro64: hook up bluetooth at uart0

[Soeren Moch]

On 12.12.19 11:22, Robin Murphy wrote:
> Hi Soeren,
>
> On 11/12/2019 11:52 pm, Soeren Moch wrote:
>> With enabled wifi support (required for firmware loading) for the
>> Ampak AP6359SA based wifi/bt combo module we now also can enable
>> the bluetooth part.
>>
>> Suggested-by: Heiko Stuebner <heiko@xxxxxxxxx>
>> Signed-off-by: Soeren Moch <smoch@xxxxxx>
>> ---
>> changes in v2:
>> - new patch
>>
>> Cc: Heiko Stuebner <heiko@xxxxxxxxx>
>> Cc: Kalle Valo <kvalo@xxxxxxxxxxxxxx>
>> Cc: linux-wireless@xxxxxxxxxxxxxxx
>> Cc: brcm80211-dev-list.pdl@xxxxxxxxxxxx
>> Cc: brcm80211-dev-list@xxxxxxxxxxx
>> Cc: netdev@xxxxxxxxxxxxxxx
>> Cc: linux-arm-kernel@xxxxxxxxxxxxxxxxxxx
>> Cc: linux-rockchip@xxxxxxxxxxxxxxxxxxx
>> Cc: linux-kernel@xxxxxxxxxxxxxxx
>> ---
>> Â .../boot/dts/rockchip/rk3399-rockpro64.dtsÂÂÂ | 29 ++++++++++++++++++-
>> Â 1 file changed, 28 insertions(+), 1 deletion(-)
>>
>> diff --git a/arch/arm64/boot/dts/rockchip/rk3399-rockpro64.dts
>> b/arch/arm64/boot/dts/rockchip/rk3399-rockpro64.dts
>> index 9fa92790d6e0..94cc462e234d 100644
>> --- a/arch/arm64/boot/dts/rockchip/rk3399-rockpro64.dts
>> +++ b/arch/arm64/boot/dts/rockchip/rk3399-rockpro64.dts
>> @@ -561,6 +561,20 @@
>> Â };
>>
>> Â &pinctrl {
>> +ÂÂÂ bt {
>> +ÂÂÂÂÂÂÂ bt_enable_h: bt-enable-h {
>> +ÂÂÂÂÂÂÂÂÂÂÂ rockchip,pins = <0 RK_PB1 RK_FUNC_GPIO &pcfg_pull_none>;
>> +ÂÂÂÂÂÂÂ };
>> +
>> +ÂÂÂÂÂÂÂ bt_host_wake_l: bt-host-wake-l {
>> +ÂÂÂÂÂÂÂÂÂÂÂ rockchip,pins = <0 RK_PA4 RK_FUNC_GPIO &pcfg_pull_down>;
>> +ÂÂÂÂÂÂÂ };
>> +
>> +ÂÂÂÂÂÂÂ bt_wake_l: bt-wake-l {
>> +ÂÂÂÂÂÂÂÂÂÂÂ rockchip,pins = <2 RK_PD3 RK_FUNC_GPIO &pcfg_pull_none>;
>> +ÂÂÂÂÂÂÂ };
>> +ÂÂÂ };
>> +
>> ÂÂÂÂÂ buttons {
>> ÂÂÂÂÂÂÂÂÂ pwrbtn: pwrbtn {
>> ÂÂÂÂÂÂÂÂÂÂÂÂÂ rockchip,pins = <0 RK_PA5 RK_FUNC_GPIO &pcfg_pull_up>;
>> @@ -729,8 +743,21 @@
>>
>> Â &uart0 {
>> ÂÂÂÂÂ pinctrl-names = "default";
>> -ÂÂÂ pinctrl-0 = <&uart0_xfer &uart0_cts>;
>> +ÂÂÂ pinctrl-0 = <&uart0_xfer &uart0_cts &uart0_rts>;
>> ÂÂÂÂÂ status = "okay";
>> +
>> +ÂÂÂ bluetooth {
>> +ÂÂÂÂÂÂÂ compatible = "brcm,bcm43438-bt";
>> +ÂÂÂÂÂÂÂ clocks = <&rk808 1>;
>> +ÂÂÂÂÂÂÂ clock-names = "extclk";
>
> Is this right? Comparing the binding and the naming on the schematics,
> it seems more likely that this might be the LPO clock rather than the
> TXCO clock.
>
> Robin.
On second thought I have to agree. So we need another round on this.

Thanks for your review and bug report,
Soeren
>
>> +ÂÂÂÂÂÂÂ device-wakeup-gpios = <&gpio2 RK_PD3 GPIO_ACTIVE_HIGH>;
>> +ÂÂÂÂÂÂÂ host-wakeup-gpios = <&gpio0 RK_PA4 GPIO_ACTIVE_HIGH>;
>> +ÂÂÂÂÂÂÂ shutdown-gpios = <&gpio0 RK_PB1 GPIO_ACTIVE_HIGH>;
>> +ÂÂÂÂÂÂÂ pinctrl-names = "default";
>> +ÂÂÂÂÂÂÂ pinctrl-0 = <&bt_host_wake_l &bt_wake_l &bt_enable_h>;
>> +ÂÂÂÂÂÂÂ vbat-supply = <&vcc3v3_sys>;
>> +ÂÂÂÂÂÂÂ vddio-supply = <&vcc_1v8>;
>> +ÂÂÂ };
>> Â };
>>
>> Â &uart2 {
>> --
>> 2.17.1
>>
>>
>> _______________________________________________
>> Linux-rockchip mailing list
>> Linux-rockchip@xxxxxxxxxxxxxxxxxxx
>> http://lists.infradead.org/mailman/listinfo/linux-rockchip
>>