Re: [PATCH] x86/resctrl: fix an imbalance in domain_remove_cpu
From: Chen Yu
Date: Thu Dec 12 2019 - 06:58:29 EST
On Wed, Dec 11, 2019 at 2:06 AM Qian Cai <cai@xxxxxx> wrote:
>
> Here it only check L3, so it will skip correctly for L3DATA and L3CODE
> to not call cancel_delayed_work(). Recalled the above that only L3 will
> have r->capable set.
>
> if (r == &rdt_resources_all[RDT_RESOURCE_L3]) {
> if (is_mbm_enabled() && cpu == d->mbm_work_cpu) {
> cancel_delayed_work(&d->mbm_over);
>
> Hence, r->mon_capable check seems redundant here.
>
I see. Thanks for explaining.
--
thanks,
Ryan