Re: [RFC 5/5] i3c: add i3cdev module to expose i3c dev in /dev
From: Greg KH
Date: Thu Dec 12 2019 - 09:45:04 EST
On Tue, Dec 10, 2019 at 04:37:33PM +0100, Vitor Soares wrote:
> +static int __init i3cdev_init(void)
> + int res;
> + pr_info("i3c /dev entries driver\n");
Please remove debugging information, kernel code should be quiet unless
something goes wrong.
> + /* Dynamically request unused major number */
> + res = alloc_chrdev_region(&i3cdev_number, 0, N_I3C_MINORS, "i3c");
Do you really need a whole major, or will a few minors work?