Re: [PATCH] arm64: dts: qcom: sc7180: Fix order of nodes
From: Matthias Kaehlcke
Date: Thu Dec 12 2019 - 15:58:28 EST
On Thu, Dec 12, 2019 at 12:45:46PM -0800, Doug Anderson wrote:
> Hi,
>
> On Thu, Dec 12, 2019 at 11:55 AM Matthias Kaehlcke <mka@xxxxxxxxxxxx> wrote:
> > + pdc: interrupt-controller@b220000 {
> > + compatible = "qcom,sc7180-pdc", "qcom,pdc";
> > + reg = <0 0xb220000 0 0x30000>;
>
> nit: when applying, maybe Bjorn / Andy could change 0xb220000 to
> 0x0b220000 to match the convention elsewhere in this file. That's not
> a new problem introduced in your patch, but it seems like it could be
> part of the same patch and it feels like a waste to re-send just for
> that. ;-)
haha, I also stumbled across this and doubted whether to change it in this
patch ;-)
Sure, I can send a v2 that includes it.
> Reviewed-by: Douglas Anderson <dianders@xxxxxxxxxxxx>
Thanks!