Re: [PATCH] sh: add missing EXPORT_SYMBOL() for __delay

From: Kuninori Morimoto
Date: Thu Dec 12 2019 - 18:57:06 EST



Hi Geert

Thank you for your feedback

> > --- a/arch/sh/lib/delay.c
> > +++ b/arch/sh/lib/delay.c
> > @@ -29,6 +29,7 @@ void __delay(unsigned long loops)
> > : "0" (loops)
> > : "t");
> > }
> > +EXPORT_SYMBOL(__delay);
> >
> > inline void __const_udelay(unsigned long xloops)
> > {
>
> I believe the correct fix is make drivers/net/phy/mdio-cavium.c use one
> of [nmu]delay() instead.
>
> Cfr.
> https://lore.kernel.org/lkml/CAMuHMdUERaoHLNKi03zCuYi7NevgBFjXrV=pt0Yy=HOeRiL25Q@xxxxxxxxxxxxxx/

OK, make sense.
I did it because some architecture is using EXPORT_SYMBOL() to __delay.

Thank you for your help !!
Best regards
---
Kuninori Morimoto