Re: [PATCH] usb: dwc3: qcom: Remove useless compatible strings from the match table

[Manu Gautam]

Thanks. Patch looks good to me.

On 12/13/2019 2:51 AM, Douglas Anderson wrote:
> The of match table in dwc3-qcom.c had an entry per Qualcomm SoC known
> to have dwc3.  That's not needed.  Here's why:
>
> 1. The bindings specify that the compatible string in the device tree
>    should contain the SoC-specific compatible string followed by the
>    string "qcom,dwc3".
>
> 2. All known Qualcomm SoC dts files (confirmed via git grep in
>    mainline Linux) using dwc3 follow the rules and do, in fact,
>    contain the SoC-specific compatible string followed by the string
>    "qcom,dwc3".
>
> 3. The source code does nothing special with the per-SoC strings--they
>    are only used to match the node.
>
> Let's remove the extra strings from the table.  Doing so will avoid
> the need to land future useless patches [1] that do nothing more than
> add yet more strings to the table.

Reviewed-by: Manu Gautam <mgautam@xxxxxxxxxxxxxx>

-- 
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project