Re: [PATCH v3] mfd: syscon: Add arguments support for syscon reference

[Lee Jones]

On Fri, 13 Dec 2019, Orson Zhai wrote:

> Hi Lee and Rob,
> 
> On Wed, Dec 11, 2019 at 02:55:39PM +0100, Arnd Bergmann wrote:
> > On Wed, Dec 11, 2019 at 5:09 AM Orson Zhai <orson.zhai@xxxxxxxxxx> wrote:
> > >
> > > There are a lot of similar global registers being used across multiple SoCs
> > > from Unisoc. But most of these registers are assigned with different offset
> > > for different SoCs. It is hard to handle all of them in an all-in-one
> > > kernel image.
> > >
> > > Add a helper function to get regmap with arguments where we could put some
> > > extra information such as the offset value.
> > >
> > > Signed-off-by: Orson Zhai <orson.zhai@xxxxxxxxxx>
> > > Tested-by: Baolin Wang <baolin.wang@xxxxxxxxxx>
> >
> > Reviewed-by: Arnd Bergmann <arnd@xxxxxxxx>
> 
> Does this patch look good to be applied?
> 
> Or if any comments please feel free to send to me.

If it looks good to Arnd, it looks good to me.

I have quite a number of reviews to get through first though, please
bear with me and resist the urge to nag.

-- 
Lee Jones [æçæ]
Linaro Services Technical Lead
Linaro.org â Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog