Re: [RFC 04/25] spi: gpio: Implement LSB First bitbang support

From: Mark Brown
Date: Fri Dec 13 2019 - 06:42:35 EST

On Thu, Dec 12, 2019 at 10:08:24PM +0100, Andreas Färber wrote:
> Am 12.12.19 um 18:19 schrieb Mark Brown:

> >>>> Duplicate the inline helpers bitbang_txrx_be_cpha{0,1} as LE versions.
> >>>> Make happy by changing "unsigned" to "unsigned int".

> > Separate patch for this?

> For the checkpatch cleanup? Or helpers preparation vs. spi-gpio.c usage?

At least the checkpatch cleanup.

> > Yeah, I don't think there's any great options here with the potential
> > performance issues - probably the nicest thing would be to autogenerate
> > lots of variants but I think that's far more trouble than it's worth.

> Maybe add another code comment to revisit that idea later then?

Sure, if you like.

Attachment: signature.asc
Description: PGP signature