Re: [PATCH 4.19 185/243] ARM: dts: sun8i: a23/a33: Fix up RTC device node

From: Pavel Machek
Date: Fri Dec 13 2019 - 06:50:43 EST

On Thu 2019-12-12 15:02:41, Greg Kroah-Hartman wrote:
> On Thu, Dec 12, 2019 at 02:31:32PM +0100, Pavel Machek wrote:
> > Hi!
> >
> > > The RTC module on the A23 was claimed to be the same as on the A31, when
> > > in fact it is not. The A31 does not have an RTC external clock output,
> > > and its internal RC oscillator's average clock rate is not in the same
> > > range. The A33's RTC is the same as the A23.
> > >
> > > This patch fixes the compatible string and clock properties to conform
> > > to the updated bindings. The register range is also fixed.
> >
> > No, this is not okay for v4.19. New compatible is not in
> > ./drivers/rtc/rtc-sun6i.c, so this will completely break rtc support.
> Good catch, I would have thought both of those would happen at the same
> time.

That's not normally how it works for dts changes. Drivers and dts very
often have different maintainers, so there is preference for them to
go in separately.

Best regards,
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany

Attachment: signature.asc
Description: PGP signature