Re: [PATCH v5 4/4] x86/mm/KASLR: Adjust the padding size for the direct mapping.

From: Borislav Petkov
Date: Fri Dec 13 2019 - 09:15:54 EST

On Fri, Dec 13, 2019 at 09:28:50PM +0800, Baoquan He wrote:
> In Documentation/x86/x86_64/mm.rst, the physical memory regions mapping
> with page_offset is called as the direct mapping of physical memory.

The fact that it happens to compute the *first* region's size, which
*happens* to be the direct mapping of all physical memory is immaterial

It is actually causing more confusion in an already complex piece of
code. You can call this function just as well


which won't confuse readers. Because all you care about here is the
region's size - not which region it is.

> kernel_randomize_memory() is invoked much earlier than
> acpi_table_parse_srat().

And? What are we going to do about that?