Re: [PATCH v3 1/2] IMA: Define workqueue for early boot "key" measurements

From: Lakshmi Ramasubramanian
Date: Fri Dec 13 2019 - 10:51:45 EST

On 12/13/19 5:06 AM, Mimi Zohar wrote:

I just need to convince myself that this is correct. ÂNormally before
reading and writing a flag, there is some sort of locking. ÂWith
taking the mutex before setting the flag, there is now only a lock
around the single writer.

Without taking a lock before reading the flag, will the queue always
be empty is the question. ÂIf it is, then the comment is correct, but
the code assumes not and processes the list again. ÂTesting the flag
after taking the mutex just re-enforces the comment.

Bottom line, does reading the flag need to be lock protected?


I'll change this function to check the flag again after taking the lock and process only if the queue has entries. Will send an update today.

Please let me know if you have any concern in other functions in this file. I'll address them, if any, in today's update.