Re: [PATCH v2] io_uring: don't wait when under-submitting
From: Jens Axboe
Date: Sat Dec 14 2019 - 09:39:31 EST
On 12/14/19 7:31 AM, Pavel Begunkov wrote:
> There is no reliable way to submit and wait in a single syscall, as
> io_submit_sqes() may under-consume sqes (in case of an early error).
> Then it will wait for not-yet-submitted requests, deadlocking the user
> in most cases.
>
> Don't wait/poll if can't submit all sqes, and return -EAGAIN
>
> Signed-off-by: Pavel Begunkov <asml.silence@xxxxxxxxx>
> ---
>
> v2: cap min_complete if submitted partially (Jens Axboe)
Can you update the commit message as well, doesn't really reflect the
current state of it... Apart from that, looks good to me!
--
Jens Axboe