Re: [PATCH 3/3] drm/panel: add panel driver for Xinpeng XPP055C272 panels

From: Sam Ravnborg
Date: Sun Dec 15 2019 - 04:40:28 EST


Hi Heiko.

> > The idea was that if a write returned an error then do not even attempt
> > more writes. So if a write fails we do not loose the original error
> > code, assuming subsequent write would also fail.
>
> Shouldn't the code above do exactly that? ... Because it's like
>
> ret = dcs_write(...)
> if (ret <0)
> return ret;
>
> So if any of the dcs_writes goes wrong it should just return the
> error code from that write from the function and not try any more
> writes. (or I'm blind and do not see something ;-) )

You are right, the code does it already.

Sam